Hi,<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 6, 2012 at 10:09 PM, Felipe Balbi <span dir="ltr"><<a href="mailto:balbi@ti.com" target="_blank">balbi@ti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Hi,<br>
<div><div class="h5"><br>
On Tue, Nov 06, 2012 at 07:23:12PM +0530, Vivek Gautam wrote:<br>
> Hi Balbi,<br>
><br>
><br>
> On Tue, Nov 6, 2012 at 6:44 PM, Felipe Balbi <<a href="mailto:balbi@ti.com">balbi@ti.com</a>> wrote:<br>
> > Hi,<br>
> ><br>
> > On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote:<br>
> >> This patchset is based on the work by Praveen Paneri for<br>
> >> samsung-usbphy driver:<br>
> >> <a href="http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653" target="_blank">http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653</a><br>
> >><br>
> >> Changes from v2:<br>
> >> - Using "EXYNOS5_PHY_" as common prefix along with exact names for<br>
> >> PHY SFRs for register definitions<br>
> >> - Using register names with bit macros to make things more clear.<br>
> >> - Removed parentheses around 0x230 in definition for EXYNOS5_USB_CFG<br>
> >> in [patch 2/4 v2].<br>
> >><br>
> >> Tested on smdk5250 target with usb-next branch along with arch patches<br>
> >> for exynos5250:<br>
> >> <a href="http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13042" target="_blank">http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13042</a><br>
> >> <a href="http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13048" target="_blank">http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13048</a><br>
> >><br>
> >> Vivek Gautam (4):<br>
> >> usb: phy: samsung: Add host phy support to samsung-phy driver<br>
> >> ARM: Exynos5250: Enabling samsung-usbphy driver<br>
> >> USB: ehci-s5p: Add phy driver support<br>
> >> USB: ohci-exynos: Add phy driver support<br>
> ><br>
> > I really don't know what to do with this series. I know it depends on<br>
> > the other PHY changes which I have in my queue, but it touches too much<br>
> > arch specific code, plus the USB Host code which I don't maintain.<br>
> ><br>
><br>
> True, that it has dependency on the work by Praveen Paneri for samsung-usbphy<br>
> driver plus the arch support patches.<br>
><br>
> This is based on usb-next branch, so the host-code can be taken care of ?<br>
><br>
> > On top of all that, I have no platform to test these patches, which<br>
> > makes me even more worried about signing off under this series ;-)<br>
> ><br>
> The patches have however been tested. The two patches:<br>
> "USB: ehci-s5p: Add phy driver support",<br>
> "USB: ohci-exynos: Add phy driver support" have been acked by Jingoo Han<br>
> based on the patch-series.<br>
><br>
> Possibly Kukjin Kim can help on this one.<br>
><br>
> Kukjin,<br>
> Can we have a thought on this please.<br>
><br>
> > Would it be ok if we delay this to v3.9 ? At least the dependency with<br>
> > other PHY changes would be dropped by then.<br>
> ><br>
> This changes are almost in shape ;-) and i am updating the next patchset soon.<br>
> If possible can we try to get this in 3.8 please. :-)<br>
<br>
</div></div>we can try, but I'd like to minimize the amount of code outside of<br>
drivers/usb/ I take in my tree. If there's any way to split the series<br>
so it makes my life easier, I'd be really glad.<br></blockquote><br>Thanks for this.<br>I have submitted v4 patch-set in this series: <a href="http://www.spinics.net/lists/linux-usb/msg73977.html">http://www.spinics.net/lists/linux-usb/msg73977.html</a><br>
This again contains some arch changes. I can minimize the arch support as far as possible.<br>Possibly i can put up following changes further in v4.<br> - Remove arch changes from [PATCH v4 1/5] ARM: EXYNOS: Update & move usb-phy types to generic include layer<br>
<br>Small arch changes in [PATCH 2/5] usb: phy: samsung: Add host phy support to samsung-phy driver,<br>in the same series (i missed v4 suffix in this :-( comes as a result of Praveen Paneri's patches<br>in the series <a href="http://www.spinics.net/lists/linux-usb/msg73518.html">http://www.spinics.net/lists/linux-usb/msg73518.html</a>, to prevent build-break.<br>
<br>Kukjin can help Ack-ing with [PATCH v4 3/5] ARM: Exynos5250: Enabling samsung-usbphy driver, since<br>this is machine specific patch.<br><br>Will this be fine ? Please suggest.<br><br><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Also, I can't apply arch/* patches without proper Acked-bys, so Kukjin<br>
would need to help us out there too :-)<br>
<br>
cheers<br>
<span class=""><font color="#888888"><br>
--<br>
balbi<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br>Thanks & Regards<br>Vivek<br>
</div>