<br><br><div class="gmail_quote">On Fri, Jun 24, 2011 at 2:34 PM, Grant Likely <span dir="ltr"><<a href="mailto:grant.likely@secretlab.ca">grant.likely@secretlab.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Fri, Jun 24, 2011 at 3:11 PM, David Brown <<a href="mailto:davidb@codeaurora.org">davidb@codeaurora.org</a>> wrote:<br>
> On Fri, Jun 24 2011, Anton Staaf wrote:<br>
><br>
>> On Fri, Jun 24, 2011 at 1:02 PM, David Brown <<a href="mailto:davidb@codeaurora.org">davidb@codeaurora.org</a>> wrote:<br>
>><br>
>><br>
>> Does this mean that the dtc inside the kernel is going to be the<br>
>> required tool to use to build device trees? This change doesn't change<br>
>> the DTB format, so it's as much of a concern, but was wondering if we're<br>
>> intending to keep things compatible.<br>
>><br>
>><br>
>> To be honest, I don't know enough to say either way. I am using the character<br>
>> literals in a device tree that is used to configure a single firmware image for<br>
>> multiple boards. That device tree is not currently passed on to the kernel.<br>
>><br>
>> Your question makes me think that there are two device tree compilers that I<br>
>> should be paying attention to, is that the case? Or was it a more general<br>
>> comment about diverging from a historic syntax for device tree source files?<br>
><br>
> Both, really. There is a dtc at<br>
> git://<a href="http://git.kernel.org/pub/scm/linux/kernel/git/galak/dtc.git" target="_blank">git.kernel.org/pub/scm/linux/kernel/git/galak/dtc.git</a> but it seems<br>
> older than the one in the kernel.<br>
<br>
</div>The kernel one is simply a copy of the upstream dtc. You should craft<br>
your patches against:<br>
<div class="im"><br>
git://<a href="http://git.jdl.com/software/dtc.git" target="_blank">git.jdl.com/software/dtc.git</a><br>
<br>
><br>
</div><div class="im">> Also, the dts form is defined in the ePAPR documents, and this would be<br>
> a (minor) divergence from that.<br>
<br>
</div>dts is not set in stone, and is certainly subject to enhancements<br>
providing it doesn't break existing users.<br>
<font color="#888888"><br></font></blockquote><div> </div></div>Adding character literals does not (as far as I can tell) conflict with any existing syntax. All exiting dts files should compile to the exact same blobs with my patches. And of coarse, all of the existing test cases pass cleanly. It would also be a good idea for me to add test cases for character literals. I will do that and update the patch set if we decide to accept the change to the syntax.<div>
<br></div><div>-Anton</div><div><br></div>