<p><br>
On Mar 30, 2011 10:23 PM, "Shawn Guo" <<a href="mailto:shawn.guo@freescale.com">shawn.guo@freescale.com</a>> wrote:<br>
><br>
> On Fri, Mar 25, 2011 at 04:48:46PM +0800, Shawn Guo wrote:<br>
> > Here are what the patch set does.<br>
> ><br>
> > * Remove .probe and .remove hooks from sdhci-pltfm.c and make it be<br>
> > a pure common helper function providers.<br>
> > * Add .probe and .remove hooks for sdhci pltfm drivers sdhci-cns3xxx,<br>
> > sdhci-dove, sdhci-tegra, and sdhci-esdhc-imx to make them self<br>
> > registered with calling helper functions created above.<br>
> > * Migrate the use of sdhci_of_host and sdhci_of_data to<br>
> > sdhci_pltfm_host and sdhci_pltfm_data, so that OF version host and<br>
> > data structure works can be saved, and pltfm version works for both<br>
> > cases.<br>
> > * Add OF common helper stuff into sdhci-pltfm.c, and make OF version<br>
> > sdhci drivers sdhci-of-esdhc and sdhci-of-hlwd become self<br>
> > registered as well, so that sdhci-of-core.c and sdhci-of.h can be<br>
> > removed.<br>
> > * Consolidate the OF and pltfm esdhc drivers into one with sharing<br>
> > the same pair of .probe and .remove hooks. As a result,<br>
> > sdhci-esdhc-imx.c and sdhci-of-esdhc.c go away, while<br>
> > sdhci-esdhc.c comes in and works for both MPCxxx and i.MX.<br>
> > * Eliminate include/linux/mmc/sdhci-pltfm.h with moving stuff into<br>
> > drivers/mmc/host/sdhci-pltfm.h.<br>
> ><br>
> > And the benefits we gain from the changes are:<br>
> ><br>
> > * Get the sdhci device driver follow the Linux trend that driver<br>
> > makes the registration by its own.<br>
> > * sdhci-pltfm.c becomes simple and clean as it only has common helper<br>
> > stuff there now.<br>
> > * All sdhci device specific things are going back its own driver.<br>
> > * The dt and non-dt drivers are consolidated to use the same pair of<br>
> > .probe and .remove hooks.<br>
> > * SDHCI driver for Freescale eSDHC controller found on both MPCxxx<br>
> > and i.MX platforms is consolidated to use the same one .probe<br>
> > function.<br>
> ><br>
> > The patch set works against the tree below, and was only tested on<br>
> > i.mx51 babbage board, all other targets were build tested.<br>
> ><br>
> > git://<a href="http://git.secretlab.ca/git/linux-2.6.git">git.secretlab.ca/git/linux-2.6.git</a> devicetree/test<br>
> ><br>
> > Comments are welcomed and appreciated.<br>
> ><br>
> > Regards,<br>
> > Shawn<br>
> ><br>
> > PS: The first patch is a squashing of the patch set below, which was<br>
> > posted for review a few days back.<br>
> ><br>
> > [PATCH 0/5] make sdhci device drivers self registered<br>
> ><br>
> > Some patches in this series are relatively large, involving more<br>
> > changes than expected, I chose to not split considering they are<br>
> > logically integral, and doing so can reduce the patch quantity much,<br>
> > and make bisect much easier. But sorry for that it makes reviewers'<br>
> > life harder.<br>
> ><br>
> > Shawn Guo (5):<br>
> > mmc: sdhci: make sdhci-pltfm device drivers self registered<br>
> > mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data<br>
> > mmc: sdhci: make sdhci-of device drivers self registered<br>
> > mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx<br>
> > mmc: sdhci: merge two sdhci-pltfm.h into one<br>
> ><br>
> > drivers/mmc/host/Kconfig | 71 ++++---<br>
> > drivers/mmc/host/Makefile | 17 +-<br>
> > drivers/mmc/host/sdhci-cns3xxx.c | 68 ++++++-<br>
> > drivers/mmc/host/sdhci-dove.c | 69 ++++++-<br>
> > drivers/mmc/host/sdhci-esdhc-imx.c | 149 -------------<br>
> > drivers/mmc/host/sdhci-esdhc.c | 412 ++++++++++++++++++++++++++++++++++++<br>
> > drivers/mmc/host/sdhci-of-core.c | 247 ---------------------<br>
> > drivers/mmc/host/sdhci-of-esdhc.c | 89 --------<br>
> > drivers/mmc/host/sdhci-of-hlwd.c | 89 +++++++-<br>
> > drivers/mmc/host/sdhci-of.h | 42 ----<br>
> > drivers/mmc/host/sdhci-pltfm.c | 251 +++++++++-------------<br>
> > drivers/mmc/host/sdhci-pltfm.h | 36 +++-<br>
> > drivers/mmc/host/sdhci-tegra.c | 187 ++++++++++-------<br>
> > include/linux/mmc/sdhci-pltfm.h | 35 ---<br>
> > 14 files changed, 912 insertions(+), 850 deletions(-)<br>
> > --<br>
><br>
> Any comments? Is this the right direction to move?</p>
<p>I think it is, but I'll try to get you a full review tomorrow.</p>
<p>g.</p>
<p>><br>
> --<br>
> Regards,<br>
> Shawn<br>
><br>
><br>
> _______________________________________________<br>
> linaro-dev mailing list<br>
> <a href="mailto:linaro-dev@lists.linaro.org">linaro-dev@lists.linaro.org</a><br>
> <a href="http://lists.linaro.org/mailman/listinfo/linaro-dev">http://lists.linaro.org/mailman/listinfo/linaro-dev</a><br>
</p>