[PATCH] of: dma.c: fix memory leakage

Rob Herring robherring2 at gmail.com
Mon Jan 21 09:24:49 EST 2013


On 01/19/2013 07:06 AM, Cong Ding wrote:
> The memory allocated to ofdma might be a leakage when error occurs.
> 
> Signed-off-by: Cong Ding <dinggnu at gmail.com>

You need to send this to whomever is working on DMA bindings.

Rob

> ---
>  drivers/of/dma.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/dma.c b/drivers/of/dma.c
> index 59631b2..583e50e3 100644
> --- a/drivers/of/dma.c
> +++ b/drivers/of/dma.c
> @@ -107,6 +107,7 @@ int of_dma_controller_register(struct device_node *np,
>  	if (!nbcells) {
>  		pr_err("%s: #dma-cells property is missing or invalid\n",
>  		       __func__);
> +		kfree(ofdma);
>  		return -EINVAL;
>  	}
>  
> 


More information about the devicetree-discuss mailing list