[ccan] [PATCH] cpuid: increment over size of cpu array, not just first one.

Rusty Russell rusty at rustcorp.com.au
Fri Nov 4 21:44:21 AEDT 2016


Found by PCS Suite.

Reported-by: Jon Griffiths
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>

diff --git a/ccan/cpuid/cpuid.c b/ccan/cpuid/cpuid.c
index 9a42d83..4510def 100644
--- a/ccan/cpuid/cpuid.c
+++ b/ccan/cpuid/cpuid.c
@@ -237,7 +237,7 @@ cputype_t cpuid_get_cpu_type(void)
 		uint32_t i;
 
 		get_cpuid(CPUID_VENDORID, &i, &u.bufu32[0], &u.bufu32[2], &u.bufu32[1]);
-		for (i = 0; i < sizeof(c_cpunames) / sizeof(c_cpunames); ++i) {
+		for (i = 0; i < sizeof(c_cpunames) / sizeof(c_cpunames[0]); ++i) {
 			if (strncmp(c_cpunames[i], u.buf, 12) == 0) {
 				cputype = (cputype_t)i;
 				break;


More information about the ccan mailing list